Fix _Ptr source location bugs and remove workarounds from 3C.#723
Draft
mattmccutchen-cci wants to merge 6 commits intoptr-source-loc.basefrom
Draft
Fix _Ptr source location bugs and remove workarounds from 3C.#723mattmccutchen-cci wants to merge 6 commits intoptr-source-loc.basefrom
_Ptr source location bugs and remove workarounds from 3C.#723mattmccutchen-cci wants to merge 6 commits intoptr-source-loc.basefrom
Conversation
Needs more work, plus we should add tests for the FVComponentVariable::SourceDeclaration cases.
mattmccutchen-cci
referenced
this pull request
Oct 14, 2021
mattmccutchen-cci
added a commit
that referenced
this pull request
Nov 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As previously discussed in #657 and here, the Checked C compiler has a bug where it returns the wrong source locations for checked pointer types (not yet submitted to Microsoft's issue tracker). I'm planning to fix that bug and then remove 3C's workarounds for the bug. This draft PR currently contains both changes for convenience. When I'm ready, I'll submit a PR to Microsoft with only the compiler changes. After that PR is accepted and merged back to our repository, I'll update this PR to contain only the 3C changes.
I think the compiler part of this PR is done, but the 3C part needs a little more work, and it's possible (though unlikely) that I'll discover more problems in the compiler part during that process. Anyone interested in the PR can go ahead and look at it, but be warned that I'll likely force-push it later.