3c no longer crashes when encountering intrinsics #633
Merged
aaronjeline merged 4 commits intomainfrom Jun 25, 2021
Merged
Conversation
aaronjeline
requested review from
john-h-kastner,
mattmccutchen-cci and
mwhicks1
kyleheadley
approved these changes
Jun 25, 2021
Member
kyleheadley
left a comment
kyleheadley
left a comment
There was a problem hiding this comment.
LGTM, but could you combine the tests into one file? They're variations on a theme and likely pass/fail together anyway.
john-h-kastner
requested changes
Jun 25, 2021
Collaborator
john-h-kastner
left a comment
john-h-kastner
left a comment
There was a problem hiding this comment.
Add the test case we looked at for a pointer to the typedef'ed vector type.
This was referenced Jun 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously 3c would crash if it found any use of intrinsic types: (ex:
int __attribute__ ((vector_size(16))) x)Now, 3c correctly identifies these as base type.
Since intrinsic vectors cannot contain pointers, we do not need to generate constraints around them.
(ie:
int* __attribute__ ((vector_size(16)))is an invalid type).As far as rewriting, if the instrinsics are behind a typedef, then rewriting works fine. However if they are used as raw types rewriting will fail as currently rewriting drops attributes. This is potentially addressed in #466.
This fixes issues: #632, #381, and #284