Fix for issue #373 by aaronjeline · Pull Request #408 · correctcomputation/checkedc-clang

aaronjeline · 2021-01-28T19:52:23Z

No description provided.

…ng into typedefs

kyleheadley · 2021-01-28T20:30:52Z

clang/lib/3C/ConstraintVariables.cpp

+  for (auto It = Vars.begin(); It != Vars.end(); It++, Idx++) {
+    getQualString(Idx, S);
+  }
+
+  return S.str();


It looks like this could generate i.e. "const const" if you have const int * const * a or something like that. So the function name is appropriate. But it seems to be used below as a single qualifier. Is that correct?

john-h-kastner

Some code formatting/testing changes + one concern about a function.

clang/test/3C/typedefs.c

clang/lib/3C/ProgramInfo.cpp

clang/lib/3C/ConstraintVariables.cpp

mattmccutchen-cci · 2021-01-29T22:19:57Z

@aaronjeline Let me know if you need help with the -base-dir constraints stuff. One thing I'll mention: my tests currently use typedefs as an example of a case that is not implemented, so now that you're implementing that case, you'll have to find a different example! 🙂 See here for some ideas or ask John.

clang/include/clang/3C/ProgramInfo.h

clang/lib/3C/ProgramInfo.cpp

clang/include/clang/3C/ProgramInfo.h

clang/lib/3C/ProgramInfo.cpp

kyleheadley · 2021-02-05T22:05:13Z

clang/test/3C/typedefs.c

+typedef int * * const a;
+//CHECK: typedef const _Ptr<_Ptr<int>> a;
+void xxx(void) {
+  a b;


Since this rewrites const (or removes it), you can add a check here, maybe even with a comment on why it's ok to add/remove it.

mattmccutchen-cci · 2021-02-08T00:29:18Z

I had an idea for a new test of the "3C generated changes to this file even though it is not allowed to write to the file" error. This code is simple but crazy enough that we may not have to update the test again for a while, if ever.

base_subdir/main.c:

void
#include "partial_defn.h"

partial_defn.h:

foo(int *x) {}

Then 3c -extra-arg=-I${PWD%/*} main.c -- in base_subdir trips the error nicely. 😁

Update: Since I have to make other changes to clang/test/3C/base_subdir/canwrite_constraints_typedef.c in #412 anyway, I'll go ahead and make the above change in #412. (Second update: Done.) That means if #412 goes in before this PR, this PR will not affect the "designed to fail" base dir test and you'll only have to add a typedef to the "designed to succeed" test. If this PR goes in before #412, you'll be able to copy the change to the "designed to fail" test from the draft of #412 into this PR.

Also change the unimplemented canWrite constraints case from a typedef to a crazy #include in anticipation of #408.

mattmccutchen-cci

I'm reviewing only the canWrite constraints portion of this PR. There are a few things I'd like to see added.

clang/test/3C/canwrite_constraints.h

clang/test/3C/root_cause.c

clang/test/3C/canwrite_constraints.h

mwhicks1

Nothing to add to open issues in the comments. Seems OK on quick glance, beyond this.

Co-authored-by: Matt McCutchen (Correct Computation) <matt@correctcomputation.com>

mattmccutchen-cci

The root-cause and canWrite stuff looks good to me now; thanks!

clang/lib/3C/ProgramInfo.cpp

john-h-kastner

I think all the substantial work is done for this PR. There are a few formatting issue I commented on, but looks good otherwise.

clang/lib/3C/ProgramInfo.cpp

clang/lib/3C/ConstraintVariables.cpp

clang/lib/3C/ConstraintBuilder.cpp

clang/test/3C/base_subdir/canwrite_constraints.c

mattmccutchen-cci

I think the parts I know about are OK modulo this comment.

clang/test/3C/base_subdir/canwrite_constraints.c

john-h-kastner

I think this is good to go. It should fix at least one of the compilation errors for Lua.

mwhicks1 · 2021-03-08T18:40:23Z

Fantastic! Let's get it in there. :)

Aaron Eline and others added 10 commits January 12, 2021 16:19

Fixed part 1 of #373

710ac7c

Actual fix

d917148

Added test

b24a251

1st draft of single-var typedef handling

efc9514

Fixed first constraint issue

7a39353

Merge branch 'main' into typedefs

e56a07c

Merge branch 'main' into typedefs

6946d67

Merge branch 'typedefs' of github.com:correctcomputation/checkedc-cla…

a544451

…ng into typedefs

Moved definedType test to count

0481898

Fixing issue #373

22a6eae

kyleheadley reviewed Jan 28, 2021

View reviewed changes

john-h-kastner requested changes Jan 28, 2021

View reviewed changes

clang/test/3C/typedefs.c Show resolved Hide resolved

clang/lib/3C/ProgramInfo.cpp Outdated Show resolved Hide resolved

clang/lib/3C/ConstraintVariables.cpp Show resolved Hide resolved

clang/lib/3C/ConstraintVariables.cpp Outdated Show resolved Hide resolved

Merge branch 'main' into typedefs

57fe480

Aaron Eline added 2 commits February 2, 2021 09:30

Fixed writing issue

70dc288

Merge branch 'main' into typedefs

156bf6c

mattmccutchen-cci reviewed Feb 2, 2021

View reviewed changes

clang/include/clang/3C/ProgramInfo.h Outdated Show resolved Hide resolved

clang/lib/3C/ProgramInfo.cpp Outdated Show resolved Hide resolved

clang/lib/3C/ProgramInfo.cpp Outdated Show resolved Hide resolved

mattmccutchen-cci reviewed Feb 2, 2021

View reviewed changes

clang/lib/3C/ProgramInfo.cpp Outdated Show resolved Hide resolved

Aaron Eline added 3 commits February 4, 2021 09:20

Fixed consistency issue w/ unwritable structs

2e597e3

Fixed macro problem

34896cb

Removed outdated TODO

185a7d5

mattmccutchen-cci reviewed Feb 4, 2021

View reviewed changes

clang/include/clang/3C/ProgramInfo.h Outdated Show resolved Hide resolved

clang/lib/3C/ProgramInfo.cpp Outdated Show resolved Hide resolved

Aaron Eline added 4 commits February 4, 2021 12:39

Added a descriptive reason for wildness root causes

20e4773

Fixed comment & style

7fe28e9

Style fixes

7c7d95d

Improved qualifier handling around typedefs

83a748d

kyleheadley reviewed Feb 5, 2021

View reviewed changes

mattmccutchen-cci added a commit that referenced this pull request Feb 8, 2021

Update regression tests for #327.

582fa94

Also change the unimplemented canWrite constraints case from a typedef to a crazy #include in anticipation of #408.

mattmccutchen-cci mentioned this pull request Feb 10, 2021

Add -output-dir and other file handling improvements #412

Merged

14 tasks

Merge branch 'main' into typedefs

b6c5274

mattmccutchen-cci mentioned this pull request Feb 18, 2021

Constraint aren't generated correctly for functions declared by typedef #437

Open

mattmccutchen-cci reviewed Feb 18, 2021

View reviewed changes

clang/test/3C/canwrite_constraints.h Outdated Show resolved Hide resolved

clang/test/3C/canwrite_constraints.h Show resolved Hide resolved

clang/test/3C/root_cause.c Outdated Show resolved Hide resolved

clang/test/3C/canwrite_constraints.h Show resolved Hide resolved

mwhicks1 reviewed Feb 18, 2021

View reviewed changes

Aaron Eline and others added 2 commits February 19, 2021 12:04

Update clang/test/3C/canwrite_constraints.h

0c3c72e

Co-authored-by: Matt McCutchen (Correct Computation) <matt@correctcomputation.com>

Update clang/test/3C/root_cause.c

7ab2c9e

Co-authored-by: Matt McCutchen (Correct Computation) <matt@correctcomputation.com>

mattmccutchen-cci mentioned this pull request Feb 19, 2021

Properly emit typedefs where the name is in the middle of the type. #441

Closed

Aaron Eline added 2 commits February 25, 2021 13:37

Updating canwrite tests

e6e1ae8

Updating canwrite tests

bea6efc

mattmccutchen-cci reviewed Feb 25, 2021

View reviewed changes

clang/lib/3C/ProgramInfo.cpp Outdated Show resolved Hide resolved

Aaron Eline added 5 commits February 25, 2021 14:16

Merge branch 'main' into typedefs

5627645

Merge branch 'main' into typedefs

956bcd1

Fix for typedef'd arrays

238e580

Fixed handling of function typedefs

34440e8

Merge branch 'main' into typedefs

7957e95

aaronjeline requested a review from john-h-kastner March 5, 2021 00:22

john-h-kastner reviewed Mar 5, 2021

View reviewed changes

clang/lib/3C/ProgramInfo.cpp Show resolved Hide resolved

clang/lib/3C/ConstraintVariables.cpp Outdated Show resolved Hide resolved

clang/lib/3C/ConstraintBuilder.cpp Outdated Show resolved Hide resolved

kyleheadley reviewed Mar 5, 2021

View reviewed changes

clang/test/3C/base_subdir/canwrite_constraints.c Outdated Show resolved Hide resolved

aaronjeline requested a review from mattmccutchen-cci March 5, 2021 17:02

Aaron Eline added 2 commits March 5, 2021 12:06

Style cleanup

79f8886

Merge branch 'main' into typedefs

67ecac9

aaronjeline requested a review from mwhicks1 March 5, 2021 19:31

mattmccutchen-cci reviewed Mar 5, 2021

View reviewed changes

clang/test/3C/base_subdir/canwrite_constraints.c Outdated Show resolved Hide resolved

Fixed typo in test

523a5a2

john-h-kastner approved these changes Mar 8, 2021

View reviewed changes

Merge branch 'main' into typedefs

260242a

john-h-kastner merged commit 906138e into main Mar 8, 2021

mattmccutchen-cci mentioned this pull request Mar 8, 2021

Typedef rewriting error for arrays #440

Closed

aaronjeline deleted the typedefs branch March 9, 2021 05:19

Conversation

aaronjeline commented Jan 28, 2021

Uh oh!

kyleheadley Jan 28, 2021

Choose a reason for hiding this comment

Uh oh!

john-h-kastner left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mattmccutchen-cci commented Jan 29, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kyleheadley Feb 5, 2021

Choose a reason for hiding this comment

Uh oh!

mattmccutchen-cci commented Feb 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mattmccutchen-cci left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mwhicks1 left a comment

Choose a reason for hiding this comment

Uh oh!

mattmccutchen-cci left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

john-h-kastner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mattmccutchen-cci left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

john-h-kastner left a comment

Choose a reason for hiding this comment

Uh oh!

mwhicks1 commented Mar 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

john-h-kastner left a comment •

edited

Loading

mattmccutchen-cci commented Feb 8, 2021 •

edited

Loading