Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d2fcc3576
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ) | ||
|
|
||
|
|
||
| model[:time_grid] = () -> range(t0, value(tf), N+1) |
There was a problem hiding this comment.
Use integer length in time_grid
N is defined via @expression(model, N, grid_size), so it becomes a JuMP expression, not an Int. Using range(..., N+1) will throw a MethodError when model[:time_grid]() is called because range expects an integer length. Other JuMP models in this repo use grid_size+1 for this reason, so any caller that inspects the time grid (plotting, postprocessing) will fail here.
Useful? React with 👍 / 👎.
No description provided.