Skip to content

test implement#200

Open
AmielMetier wants to merge 13 commits intomainfrom
198-dev-new-problems
Open

test implement#200
AmielMetier wants to merge 13 commits intomainfrom
198-dev-new-problems

Conversation

@AmielMetier
Copy link
Collaborator

No description provided.

@AmielMetier AmielMetier linked an issue Feb 7, 2026 that may be closed by this pull request
@github-actions github-actions bot requested a review from ocots February 7, 2026 22:25
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1d2fcc3576

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

)


model[:time_grid] = () -> range(t0, value(tf), N+1)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use integer length in time_grid

N is defined via @expression(model, N, grid_size), so it becomes a JuMP expression, not an Int. Using range(..., N+1) will throw a MethodError when model[:time_grid]() is called because range expects an integer length. Other JuMP models in this repo use grid_size+1 for this reason, so any caller that inspects the time grid (plotting, postprocessing) will fail here.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dev] New Problems

2 participants