-
Notifications
You must be signed in to change notification settings - Fork 133
krun-sys: update bindgen dependency to v0.72.1 #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
It looks like the CI failed due to unrelated (?) issues. If they are not unrelated, then please tell me how to fix them. Because as far as I can tell, the current cargo "workspace but not actually workspace" setup is just broken. 🤷🏼 |
|
@decathorpe Thanks a lot for helping fix this. The DCO test is failing because the commit is missing a |
|
Thanks for the PR! Yeah the workspace setup is confusing, but the setup is not broken per se, it could use some recognizing though. I guess we should at least exclude the The CI failures are valid, the CI is failing because you haven't regenerated the Cargo.lock files to use the new dependency version. |
|
I have re-pushed with a sign-off commit.
I cannot do this. cargo refuses to update the lockfile (or do anything at all) with the error message I posted in my initial message. |
Note that, there shouldn't be a |
Signed-off-by: Fabio Valentini <decathorpe@gmail.com>
Oh, I didn't realize that there were multiple Cargo.lock file in the repository ... that is quite cursed. I've pushed again, this time updating the Cargo.lock files in examples/ and tests/. |
|
Please run something like |
It appears that this dependency was already updated in krun_display and krun_input, but not in krun-sys.
This is part of an upcoming effort to update packages that depend on bindgen in Fedora Linux to bindgen >= 0.72.1 to prevent breakage with LLVM 22 in Fedora 44+ (see https://fedoraproject.org/wiki/Changes/Bump_Minimum_Rust_Bindgen_To_v0.72 for context).
Note that there appears to be an issue with the current project layout (crates in subdirectories that look like workspace members but are not) - even running
cargo checkin thekrun-syssubdirectory fails with recent Rust versions, so I'm not sure how this subproject is handled: