Libnetwork: Refactor to use deterministic network order#689
Open
mheon wants to merge 1 commit intocontainers:mainfrom
Open
Libnetwork: Refactor to use deterministic network order#689mheon wants to merge 1 commit intocontainers:mainfrom
mheon wants to merge 1 commit intocontainers:mainfrom
Conversation
mheon
force-pushed
the
ordered_networks
branch
3 times, most recently
from
4a56159 to
ede40e6
Compare
|
Packit jobs failed. @containers/packit-build please check. |
Member
Author
|
Going to add my commit to build NV from source to see if the tests start passing |
Member
Author
|
Abandoning that plan since c/common doesn't actually have a Cirrus setup script and I don't feel like hacking one out that will just be ripped out once we get a proper NV build out. This can stay draft until we have a fresh NV ready to test with in the VMs. |
Member
|
#705 is merged |
mheon
force-pushed
the
ordered_networks
branch
2 times, most recently
from
2f56e57 to
a1d6eed
Compare
Replace map[string]PerNetworkOptions - which does not convey a deterministic order as to when networks are processed - with []NamedPerNetworkOptions, which has a defined iteration order. As we lose the key of the map (network named), we have to stick it in the struct (NamedPerNetworkOptions, which is a PerNetworkOptions with a string added). This should be compatible with the new Netavark JSON format added in containers/netavark#1369 by @Luap99 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
Member
Author
|
containers/buildah#6722 for Buildah testing Dropping WIP, though I do need to get everything rebased |
mheon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace map[string]PerNetworkOptions - which does not convey a deterministic order as to when networks are processed - with []NamedPerNetworkOptions, which has a defined iteration order. As we lose the key of the map (network named), we have to stick it in the struct (NamedPerNetworkOptions, which is a
PerNetworkOptions with a string added).
This should be compatible with the new Netavark JSON format added in containers/netavark#1369 by @Luap99
This is NOT fully tested, but since I needed to push to vendor into Podman/Buildah to make that testing happen, I figured I'd open a draft PR.