adaptation,stub: exchange NRI versions in use.#271
Open
klihub wants to merge 3 commits intocontainerd:mainfrom
Open
adaptation,stub: exchange NRI versions in use.#271klihub wants to merge 3 commits intocontainerd:mainfrom
klihub wants to merge 3 commits intocontainerd:mainfrom
Conversation
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Exchange NRI versions in use during plugin registration. If we do not get an NRI version from the runtime (too old peer NRI) try to infer it using the runtime type and version. The NRI version in use is discovered using the golang runtime provided build info. For plugins hosted in the main NRI repo this does not produce any useful result (because NRI is subject to a replace directive in the plugins' go.mod). Therefore within the repo we fall back to using a git-describe generated version. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Add version exchange test and related test option to adaptation. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds NRI version to the pieces of information exchanged between a plugin and the runtime during plugin registration.
@mikebrow @samuelkarp @chrishenzie I split this out from #265 for easier review. These are self-contained and do not depend on the rest in #265. Some bits there (version based inferred capabilities for old releases) depend on this, but I'm not sure if there is consensus about adding capability advertisement in the first place. If there is we'll just need to merge this first then rebase.