fix(deparser): emit EXCLUDE clause in window frame specifications#283
Open
gwinchesters wants to merge 2 commits intoconstructive-io:mainfrom
Open
fix(deparser): emit EXCLUDE clause in window frame specifications#283gwinchesters wants to merge 2 commits intoconstructive-io:mainfrom
gwinchesters wants to merge 2 commits intoconstructive-io:mainfrom
Conversation
|
Thanks @gwinchesters for the implementation 🙏 . @pyramation any chance you could take a look at this PR? We are having to use a patched version to support this for now and would appreciate being able to remain on the standard release versioning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #282
formatWindowFramein the deparser was silently droppingEXCLUDE CURRENT ROW,EXCLUDE GROUP, andEXCLUDE TIESwhen deparsing window frame specifications.Root cause: Hardcoded exact-match comparisons on
frameOptions(e.g.=== 789,=== 1077) failed when any EXCLUDE bit was set, since the EXCLUDE bits change the integer value. Additionally, the function never checked for or emitted the EXCLUDE bits.Fix:
0x8000,0x10000,0x20000) before exact-match comparisonsTest plan