Uncomment disabled workflow triggers and test entries#716
Closed
pyramation wants to merge 3 commits intomainfrom
Closed
Uncomment disabled workflow triggers and test entries#716pyramation wants to merge 3 commits intomainfrom
pyramation wants to merge 3 commits intomainfrom
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uncomment disabled workflow triggers and test entries
Summary
During the v5 migration, several workflow sections were temporarily commented out to speed up CI. This PR re-enables them now that the migration is finalized:
.github/workflows/docker.yaml: Uncommentedpush/pull_requesttriggers (were commented out during v5 migration)..github/workflows/run-tests.yaml: Uncommentedjobs/knative-job-workertest matrix entry.Review & Testing Checklist for Human
knative-job-workertests are failing in CI — the test attempts to connect to PostgreSQL asrootinstead ofpostgres, producingFATAL: role "root" does not exist. This is a pre-existing issue that was hidden while the test was commented out. Decide whether to fix the test config in this PR or a follow-up.node-sqitchDocker build is also failing — the Dockerfile downloadscpmfromhttps://git.io/cpm, which appears to be broken (returns invalid content). This is an external infrastructure issue unrelated to this PR. Decide whether this needs to be addressed before merging.main/v1/release/*and PRs tomain/v1whendocker/**or the workflow file changes. Confirm this matches the desired branching strategy.Recommended test plan: Both non-required CI checks (
knative-job-workerandnode-sqitchDocker build) are currently failing due to pre-existing issues. All 41 other checks pass. Review the two failures and decide whether they need fixes before or after merging this PR.Notes
knative-job-workerfailure likely needs a fix to its test setup (e.g., settingPGUSER=postgresor adjusting the test's connection config).node-sqitchDocker build failure is caused bygit.ioURL shortener returning invalid content — this will need the Dockerfile updated to use a direct URL forcpm.Link to Devin run: https://app.devin.ai/sessions/28b19aa472a64dc3b9831d510a3fe15f
Requested by: @pyramation