Skip to content

Uncomment disabled workflow triggers and test entries#716

Closed
pyramation wants to merge 3 commits intomainfrom
upgrade/v5-merge
Closed

Uncomment disabled workflow triggers and test entries#716
pyramation wants to merge 3 commits intomainfrom
upgrade/v5-merge

Conversation

@pyramation
Copy link
Contributor

@pyramation pyramation commented Feb 13, 2026

Uncomment disabled workflow triggers and test entries

Summary

During the v5 migration, several workflow sections were temporarily commented out to speed up CI. This PR re-enables them now that the migration is finalized:

  • .github/workflows/docker.yaml: Uncommented push/pull_request triggers (were commented out during v5 migration).
  • .github/workflows/run-tests.yaml: Uncommented jobs/knative-job-worker test matrix entry.

Note: The explorer v5 updates (server.ts rewrite, dependency upgrades, tsconfig changes) that were originally part of this branch were already merged into main via PR #715. After resolving merge conflicts, those changes are no longer part of this PR's diff.

Review & Testing Checklist for Human

  • knative-job-worker tests are failing in CI — the test attempts to connect to PostgreSQL as root instead of postgres, producing FATAL: role "root" does not exist. This is a pre-existing issue that was hidden while the test was commented out. Decide whether to fix the test config in this PR or a follow-up.
  • node-sqitch Docker build is also failing — the Dockerfile downloads cpm from https://git.io/cpm, which appears to be broken (returns invalid content). This is an external infrastructure issue unrelated to this PR. Decide whether this needs to be addressed before merging.
  • Verify docker workflow triggers are appropriate — the uncommented triggers will now fire on pushes to main/v1/release/* and PRs to main/v1 when docker/** or the workflow file changes. Confirm this matches the desired branching strategy.

Recommended test plan: Both non-required CI checks (knative-job-worker and node-sqitch Docker build) are currently failing due to pre-existing issues. All 41 other checks pass. Review the two failures and decide whether they need fixes before or after merging this PR.

Notes

  • Both CI failures are non-required checks, so the PR is mergeable as-is.
  • The knative-job-worker failure likely needs a fix to its test setup (e.g., setting PGUSER=postgres or adjusting the test's connection config).
  • The node-sqitch Docker build failure is caused by git.io URL shortener returning invalid content — this will need the Dockerfile updated to use a direct URL for cpm.

Link to Devin run: https://app.devin.ai/sessions/28b19aa472a64dc3b9831d510a3fe15f
Requested by: @pyramation

@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@devin-ai-integration devin-ai-integration bot changed the title Re-enable disabled builds, uncomment workflow entries, update explorer for v5 Uncomment disabled workflow triggers and test entries Feb 13, 2026
@pyramation pyramation closed this Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant