This repository was archived by the owner on Mar 12, 2026. It is now read-only.
Eliminate .toDouble roundtrips in opaque type arithmetic#134
Merged
Conversation
- FirmInit/FirmEntry: use PLN * Double and PLN * Ratio directly instead of PLN(x.toDouble * y.toDouble) - Jst: propertyTax uses PLN * Double / 12.0 - Household: social800Rate uses PLN * Double - EquityInit: separate PLN construction from Ratio multiplication - PriceEquityStep: klRatios(i) * Double instead of unwrap-multiply-wrap - Firm: push .toDouble to boundary (Ratio arithmetic stays in Ratio) - Banking: nplRatio * factor stays as Ratio, .toDouble at boundary - CorporateBondMarket: cyclicalSpread computed as Rate, not Double
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PLN(x.toDouble * y.toDouble)/Ratio(a.toDouble OP b.toDouble)to direct opaque type arithmeticPLN * Double,PLN * Ratio,Ratio * Doubleoperators used instead of unwrap-compute-rewrap.toDoublepushed to boundaries only (rng comparison, Math.min on mixed types, kahanSumBy)Test plan
sbt compile— 0 errorssbt test— all pass