fix(popover-inline): prevent scrollbars from appearing in Safari#2991
Open
danielalanbates wants to merge 1 commit intocodex-team:nextfrom
Open
fix(popover-inline): prevent scrollbars from appearing in Safari#2991danielalanbates wants to merge 1 commit intocodex-team:nextfrom
danielalanbates wants to merge 1 commit intocodex-team:nextfrom
Conversation
The base popover's `.ce-popover__items` has `overflow-y: auto`, which causes Safari to render visible scrollbars on the inline toolbar. Since the inline popover container uses `width: max-content` and grows to fit its content, scrolling is not needed. Override `overflow-y` to `visible` in the inline popover items to prevent Safari from showing scrollbars. Fixes codex-team#2988 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
danielalanbates
requested review from
TatianaFomina,
gohabereg,
ilyamore88 and
neSpecc
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2988
Summary
In Safari, the inline toolbar popover shows native scrollbars that partially cover the toolbar items. This happens because the base
.ce-popover__itemsclass setsoverflow-y: auto, and Safari renders visible scrollbars even when content doesn't overflow.Root Cause
The base popover styles (
popover.css) setoverflow-y: autoon.ce-popover__itemsto enable scrolling in dropdown popovers with many items. However, the inline toolbar already useswidth: max-contenton its container, meaning it grows to fit content rather than constraining to a fixed width. Scrolling is unnecessary for the inline toolbar.Fix
Added
overflow-y: visibleto.ce-popover__itemsinside the.ce-popover--inlinescope, overriding the base popover'soverflow-y: auto. This follows the maintainer's suggested approach #1 from the issue: disable scrolling in the inline toolbar and let it grow based on content.How to test
This PR was created with the assistance of Claude Opus 4.6 by Anthropic. Happy to make any adjustments! Reviewed and submitted by a human.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com