🤖 feat: add F4 alternate command palette shortcut#2487
Open
ethanndickson wants to merge 1 commit intomainfrom
Open
🤖 feat: add F4 alternate command palette shortcut#2487ethanndickson wants to merge 1 commit intomainfrom
ethanndickson wants to merge 1 commit intomainfrom
Conversation
- add OPEN_COMMAND_PALETTE_ACTIONS bound to F4 - open command palette with ">" when alternate shortcut is used - keep primary Ctrl/Cmd+Shift+P behavior unchanged - show alternate shortcut on the same keybind row in Settings - update onboarding tip and docs shortcut reference - add keybind matcher test coverage for F4 --- _Generated with `mux` • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh` • Cost: `$2.63`_ <!-- mux-attribution: model=openai:gpt-5.3-codex thinking=xhigh costs=2.63 -->
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a browser-safe alternate command-palette shortcut (
F4) that opens directly in command mode with>prefilled, while preservingCmd/Ctrl+Shift+Pfor default workspace-switch mode.Background
Ctrl/Cmd+Shift+Pcan be intercepted in browser contexts (especially Firefox), which makes the palette harder to reach. Earlier alternate-shortcut work was removed due conflicts with other function keys, but theinitialQueryplumbing remained in place.Implementation
KEYBINDS.OPEN_COMMAND_PALETTE_ACTIONSbound toF4.App.tsxshortcut handling to use a single combined branch for both palette keybinds:openCommandPalette(">")KEYBIND_DISPLAY_ALTERNATES.F4.OPEN_COMMAND_PALETTE_ACTIONSkey matching.Validation
bun test src/browser/utils/ui/keybinds.test.tsmake typecheckmake lintmake static-checkRisks
Low risk. The change is scoped to keybinding registration/display and command-palette open wiring. Primary shortcut behavior remains unchanged.
Generated with
mux• Model:openai:gpt-5.3-codex• Thinking:xhigh• Cost:$2.63