Skip to content

Conversation

@quintesse
Copy link
Contributor

No description provided.

@quintesse quintesse requested a review from Copilot September 2, 2025 22:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for @argument-files functionality to jpm, allowing long command lines to be written to temporary files and referenced with @ syntax. This is particularly useful for Java commands that exceed OS command line length limits.

  • Introduces argument file support with @[...] syntax that writes content to temporary files
  • Adds automatic command length detection to use argument files when needed
  • Implements smart command parsing with automatic substitution suggestions

Reviewed Changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/main/java/org/codejive/jpm/util/ScriptUtils.java Core implementation of argument file support and command processing
src/main/java/org/codejive/jpm/util/CommandsParser.java New parser for shell command syntax to enable smart substitutions
src/main/java/org/codejive/jpm/util/SyncResult.java Renamed from SyncStats and added files list tracking
src/main/java/org/codejive/jpm/util/FileUtils.java Updated to use SyncResult and added file attribute copying
src/main/java/org/codejive/jpm/Main.java Added new exec command and updated references to SyncResult
src/main/java/org/codejive/jpm/Jpm.java Refactored command execution and updated return types
src/test/java/org/codejive/jpm/util/ScriptUtilsTest.java Comprehensive test coverage for new argument file functionality
src/test/java/org/codejive/jpm/DoCommandPerformanceTest.java Updated tests for simplified executeScript signature
Comments suppressed due to low confidence (1)

src/main/java/org/codejive/jpm/util/ScriptUtils.java:1

  • The artifactsToDelete.remove(artifactName) call has been moved outside the condition checks. This means artifacts will be removed from the deletion list even if the copy operation fails or is skipped, which could lead to incorrect deletion behavior.
package org.codejive.jpm.util;

@quintesse quintesse merged commit 0b731d4 into main Sep 2, 2025
2 checks passed
@quintesse quintesse deleted the cmd_parser branch September 2, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants