fix: not recommended patterns are now included in semgrep config CF-1809 #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
pedrobpereira
force-pushed
the
fix/semgrep-config-CF-1809
branch
3 times, most recently
from
a30823c to
8131133
Compare
pedrobpereira
force-pushed
the
fix/semgrep-config-CF-1809
branch
11 times, most recently
from
80d9d78 to
091f086
Compare
machadoit
previously approved these changes
Sep 18, 2025
| // Create a map of enabled pattern IDs for faster lookup | ||
| enabledPatterns := make(map[string]bool) | ||
| for _, pattern := range config { | ||
| if pattern.Enabled && pattern.PatternDefinition.Enabled { |
|
|
||
| onlyRecommendedPatterns := make([]domain.PatternConfiguration, 0) | ||
| for _, pattern := range allPaterns { | ||
| if pattern.PatternDefinition.Enabled { |
Contributor
There was a problem hiding this comment.
This one here is fine beucase it is about the global patterns, not repo specific ones, right?
Contributor
Author
There was a problem hiding this comment.
yeah, this is platform default patterns, recommended, so that Enabled true.
pedrobpereira
force-pushed
the
fix/semgrep-config-CF-1809
branch
from
091f086 to
a765c93
Compare
machadoit
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.