fix: use atomic writes for parallel WAL restore spool

[lambcode-unified]

Fixes cloudnative-pg/cloudnative-pg#10092: a race condition where MoveOut could read partially-Summary

Fixes a race condition in parallel WAL restore (cloudnative-pg/cloudnative-pg#10092) that can cause PostgreSQL recovery to fail with "invalid checkpoint record" errors when maxParallel > 1.

Problem

When restoring WAL files in parallel, prefetched files are written directly to the spool directory with their final filename. If PostgreSQL requests a file while it's still being downloaded, MoveOut()
can copy a partially-written file to pg_wal/, causing recovery to fail.

Timeline of race condition:
T0: Goroutine starts downloading WAL-B to spool/WAL-B
T1: Download in progress (file partially written)
T2: PostgreSQL requests WAL-B
T3: MoveOut() sees file exists, copies partial file to pg_wal/
T4: PostgreSQL reads corrupt WAL → "invalid checkpoint record"

Solution

Use atomic writes with a staging pattern:

1. Download prefetched WALs to .tmp in the spool directory
2. After successful download, atomically rename .tmp to final name
3. Contains() and MoveOut() only see files without .tmp suffix

Since the temp file and final file are on the same filesystem, os.Rename() is atomic on POSIX systems - there's no window where a partial file is visible.

Changes

• pkg/spool/spool.go: Added TempFileName(), Commit(), and CleanupTemp() methods
• pkg/restorer/restorer.go: Modified RestoreList() to use temp files for prefetched WALs
• pkg/spool/spool_test.go: Added 7 tests including race condition verification

Testing

=== RUN TestCatalog
Ran 10 of 10 Specs in 0.003 seconds
SUCCESS! -- 10 Passed | 0 Failed | 0 Pending | 0 Skipped

Key tests that verify the fix:

• Contains does NOT see temp files
• MoveOut does NOT see temp files

[leonardoce]

Thank you @lambcode-unified for your contribution! Can you please sign-off your commit?

[lambcode-unified]

Thank you @lambcode-unified for your contribution! Can you please sign-off your commit?

Done!

[leonardoce]

I tested it manually with replica clusters and with the barman-cloud CNPG-i plugin.
It fixes the issues correctly. I'm approving it.