Skip to content

Remove webtypy from python workers template#12964

Open
ryanking13 wants to merge 4 commits intomainfrom
doc-webtypy
Open

Remove webtypy from python workers template#12964
ryanking13 wants to merge 4 commits intomainfrom
doc-webtypy

Conversation

@ryanking13
Copy link
Contributor

@ryanking13 ryanking13 commented Mar 19, 2026

Tidying up the Python workers template. webtypy is only for typing should not be a runtime dependency.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: It only updates the template
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: It only updates the template

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@ryanking13 ryanking13 requested review from a team, danlapid, dom96, hoodmane and joesepi March 19, 2026 04:49
@ryanking13 ryanking13 requested a review from a team as a code owner March 19, 2026 04:49
@changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2026

🦋 Changeset detected

Latest commit: d271727

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod
Copy link
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • packages/create-cloudflare/templates/hello-world-durable-object-with-assets/py/pyproject.toml: [@cloudflare/wrangler]
  • packages/create-cloudflare/templates/hello-world-durable-object/py/pyproject.toml: [@cloudflare/wrangler]
  • packages/create-cloudflare/templates/hello-world-with-assets/py/pyproject.toml: [@cloudflare/wrangler]
  • packages/create-cloudflare/templates/hello-world/py/pyproject.toml: [@cloudflare/wrangler]

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 19, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12964

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12964

miniflare

npm i https://pkg.pr.new/miniflare@12964

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12964

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12964

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12964

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12964

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12964

wrangler

npm i https://pkg.pr.new/wrangler@12964

commit: d271727

Copy link
Contributor

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, looking at our docs I see that it suggests putting workers-runtime-sdk as a dev dependency: https://developers.cloudflare.com/workers/languages/python/basics/#types-and-autocompletion.

Should we do the same here? @hoodmane are those docs up to date?

@hoodmane
Copy link
Contributor

Yeah I think including workers-runtime-sdk is a good idea.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2026

⚠️ Issues found

File: .changeset/yellow-falcons-cheat.md

  1. Description format: The title should use imperative mood (e.g., "Add workers-runtime-sdk and remove webtypy from Python workers template"), not present tense ("now includes").

  2. Missing body: The changeset has no body paragraph. The README requires a body explaining the reason for the change and anything notable about it. Why is workers-runtime-sdk being added? Why is webtypy being removed? Users and reviewers need this context in the changelog.

  3. Possible typo: "webtypy" — confirm this is the correct package name (possibly "webtypio"?).

  4. Version type: minor is accepted given it's a template scaffold change (what gets generated for users), not a pure internal dev-dependency change.

devin-ai-integration[bot]

This comment was marked as resolved.

Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

4 participants