[miniflare] Exclude metadata.sqlite from DO object listing#12960
Merged
petebacondarwin merged 2 commits intomainfrom Mar 19, 2026
Merged
[miniflare] Exclude metadata.sqlite from DO object listing#12960petebacondarwin merged 2 commits intomainfrom
petebacondarwin merged 2 commits intomainfrom
Conversation
An upcoming workerd change (cloudflare/workerd#6104) stores per-namespace alarm metadata in a metadata.sqlite file alongside per-actor .sqlite files. Filter it out so it isn't counted as a Durable Object instance.
🦋 Changeset detectedLatest commit: 6a6d740 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
Contributor
|
✅ All changesets look good |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
petebacondarwin
approved these changes
Mar 19, 2026
NuroDev
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the workers-sdk test failure caused by cloudflare/workerd#6104.
That workerd PR stores per-namespace Durable Object alarm metadata in a new
metadata.sqlitefile alongside the per-actor<objectId>.sqlitefiles. The local explorer's DO object listing treats every.sqlitefile in a namespace directory as a DO instance, sometadata.sqlitewas being counted as a spurious object—breaking both the "lists objects with stored data" and "supports cursor pagination" assertions.This filters out
metadata.sqliteso only actual DO actor files are enumerated.