fix: components to be included in the signatureHeaders#77
Merged
thibmeu merged 1 commit intocloudflare:mainfrom Mar 6, 2026
Conversation
edevil
approved these changes
Mar 6, 2026
thibmeu
reviewed
Mar 6, 2026
Collaborator
thibmeu
left a comment
There was a problem hiding this comment.
looks good overall. one suggestion to make it work for components with parameters, and another suggestion to use a generic name for headers in test instead of being tied to a product
5b81ffd to
ef97940
Compare
Contributor
Author
Thanks for the review, I squash committed all you improvements :) |
thibmeu
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: custom components crash in
getSigningOptions()Problem
Passing custom
componentstosignatureHeaders()crashes with:This happens because
getSigningOptions()has two bugs on the same line:componentsis an uninitialized local variable — should beparams.components"SIGNATURE_AGENT_HEADER"is a string literal — should be the variableSIGNATURE_AGENT_HEADER("signature-agent")The bug was never caught because the default code path (no custom components) skips this branch entirely.
Fix
Tests
Added tests covering custom components:
crawler-max-price) includes them inSignature-Inputsignature-agentwhen the header is present on the request