rust: Support client controlled signers#76
Merged
AkshatM merged 2 commits intocloudflare:mainfrom Mar 6, 2026
Merged
Conversation
cameronfyfe
changed the title
thibmeu
approved these changes
Mar 6, 2026
| message: &mut impl UnsignedMessage, | ||
| expires: Duration, | ||
| algorithm: Algorithm, | ||
| signing_key: &Vec<u8>, |
Collaborator
There was a problem hiding this comment.
this is a great change! Looks good to me and is a great addition
AkshatM
approved these changes
Mar 6, 2026
Contributor
AkshatM
left a comment
AkshatM
left a comment
There was a problem hiding this comment.
Looks good to me. Can you please update the version in Cargo.toml to 0.6.1? That'll trigger an automatic release on merge.
Contributor
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #75
This PR adds a
GenerateSignaturetrait so callers have the option of passing in their own signing logic. This enables the crate to be used with things like yubikeys, cloud kms, etc.The public API is backwards compatible (
&Vec<u8>can still be passed in) with just an argument name change fromsigning_keytosignerto indicate other custom signer types can also be used now.There are some clippy breakages to the public API since things like
&[u8]are now also possible to pass in so clippy will want something liketo simplify to