Skip to content

Fix type overrides for Uint8Array's toBase64 and fromBase64 leaking into capnweb's public interface.#148

Merged
kentonv merged 1 commit intomainfrom
kenton/fix-toBase64-type-leak
Mar 9, 2026
Merged

Fix type overrides for Uint8Array's toBase64 and fromBase64 leaking into capnweb's public interface.#148
kentonv merged 1 commit intomainfrom
kenton/fix-toBase64-type-leak

Conversation

@kentonv
Copy link
Member

@kentonv kentonv commented Mar 9, 2026

These type overrides were meant for type-checking Cap'n Web's own code, but the TS compiler "helpfully" shlepped them into the public index.d.ts for the capnweb package, affecting dependent builds. Oops!

@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2026

🦋 Changeset detected

Latest commit: 9f5680f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
capnweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 9, 2026

Open in StackBlitz

npm i https://pkg.pr.new/cloudflare/capnweb@148

commit: 9f5680f

…nto capnweb's public interface.

These type overrides were meant for type-checking Cap'n Web's own code, but the TS compiler "helpfully" shlepped them into the public `index.d.ts` for the capnweb package, affecting dependent builds. Oops!
@kentonv kentonv force-pushed the kenton/fix-toBase64-type-leak branch from a251518 to 9f5680f Compare March 9, 2026 21:46
@kentonv kentonv merged commit 189fa79 into main Mar 9, 2026
7 checks passed
@kentonv kentonv deleted the kenton/fix-toBase64-type-leak branch March 9, 2026 21:48
@github-actions github-actions bot mentioned this pull request Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants