fix: add ConfigureAwait(false) throughout async code to prevent synchronization context deadlocks#30
Merged
josiasmontag merged 2 commits intocloudconvert:masterfrom Mar 13, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users calling any
asyncmethod onCloudConvertAPI(CreateJobAsync(),UploadAsync(),WaitJobAsync(), etc.) in environments with a synchronization context (ASP.NET classic, WinForms, WPF) would experience a deadlock if the call chain blocked anywhere with.Resultor.Wait().Fix
ConfigureAwait(false)to everyawaitcall inWebApiHandlerandRestHelper, so continuations resume on any available thread pool thread rather than the captured synchronization context.RestHelper.RequestAsync<T>()to short-circuit onHTTP 204 NoContentbefore attempting to read the response body, avoiding an unnecessaryReadAsStringAsync()call.Fixes: #14
References