major changes for compatibility and usability#77
Open
michealespinola wants to merge 20 commits intocleanbrowsing:masterfrom
Open
major changes for compatibility and usability#77michealespinola wants to merge 20 commits intocleanbrowsing:masterfrom
michealespinola wants to merge 20 commits intocleanbrowsing:masterfrom
Conversation
1. Removed `bc` requirement and use `awk` instead, for systems that do not have `bc` for integer maths 1. Revamp how arrays are built and sanitized 1. Automatically detect and test against self-hosted DNS (checks for port 53 use and adds 127.0.0.1 to the nameserver list) 1. Auto-number resolv.conf nameservers to distinguish listings 1. Revamp internal DNS Provider and Domains 2 Test lists, compensating for bad entries and adding the ability to add comments lines 1. Modify logging to be as compact as reasonably possible. Providers column is now dynamically sized 1. Display corresponding Domains 2 Test list at end so we know which tests were to what
1. Code syntax revisions/compressions 2. Default display optimized for testing 13 domain names for median response times 3. Added more default domains to test 4. Added more default DNS providers to test 5. Automatically display output sorted by fastest median response time 6. Automatically save sorted list to file
This documentation is super basic. I need to come back to this and make proper write-ups of what has been changed and how it works. But the example output should make a lot of it obvious once you use the script or if you have experience with the original version.
1. Added column header lines to output log 2. Refined median response time sort to compensate for column header lines 3. Refined syntax to scrape and process BASH_SOURCE[0] instead of $0
* Externalized DNS and testing domains lists to separate text files * Changed various code for greater shellcheck compliance * Changed repeating code into functions * Changed query results breakdowns
* Further reduced subshell use * Fixed logging naming conventions * Removed last uses of echo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bcrequirement and useawkinstead, for systems that do not havebcfor integer maths