Skip to content

Syntax checking for scripts#419

Open
tpowell-progress wants to merge 3 commits intomainfrom
tp/syntax-validation
Open

Syntax checking for scripts#419
tpowell-progress wants to merge 3 commits intomainfrom
tp/syntax-validation

Conversation

@tpowell-progress
Copy link
Contributor

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: Thomas Powell <thomas.powell@progress.com>
@tpowell-progress tpowell-progress requested review from a team and jaymzh as code owners February 10, 2026 21:58
workflow_call:

permissions:
contents: read

Check notice

Code scanning / SonarCloud

Read permissions should be defined at the job level Low

Move this read permission from workflow level to job level. See more on SonarQube Cloud
Signed-off-by: Thomas Powell <thomas.powell@progress.com>
Signed-off-by: Thomas Powell <thomas.powell@progress.com>
@sonarqubecloud
Copy link

@Stromweld
Copy link
Contributor

Looks like it's not failing the job properly when there are findings https://github.com/chef/mixlib-install/actions/runs/21884292128/job/63175040749?pr=419#step:6:10

@tpowell-progress
Copy link
Contributor Author

Looks like it's not failing the job properly when there are findings https://github.com/chef/mixlib-install/actions/runs/21884292128/job/63175040749?pr=419#step:6:10

🤔 looks like those are all warnings, but i'll need to think about them

@Stromweld
Copy link
Contributor

for some reason the job name says warnings only. But the very first one in that job is an error.

In ./.expeditor/run_linux_tests.sh line 15:
bundle exec $@
            ^-- SC2068 (error): Double quote array expansions to avoid re-splitting elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants