fix: preserve ANTLR ATN data in rolldown build#738
Merged
lcottercertinia merged 1 commit intocertinia:mainfrom Mar 9, 2026
Merged
fix: preserve ANTLR ATN data in rolldown build#738lcottercertinia merged 1 commit intocertinia:mainfrom
lcottercertinia merged 1 commit intocertinia:mainfrom
Conversation
4d1adb5 to
32cb61d
Compare
The oxc printer replaces lone surrogates (0xD800-0xDFFF) with U+FFFD in long CJS strings, corrupting ANTLR's serialized ATN data and crashing the "Go to Source" feature with IllegalStateException. Add a preserveAntlrATN transform plugin that converts ATN string literals to String.fromCharCode() arrays before the oxc printer processes them, since numeric values are immune to re-serialization bugs. Also fix rolldown lana config: add missing resolve.alias for apex-log-parser, add keepNames to output, and align SWC minify options with rollup config. Upstream: oxc-project/oxc#3526 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
32cb61d to
7a0c41d
Compare
lcottercertinia
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IllegalStateException: undefined) when extension is built with rolldownpreserveAntlrATNtransform plugin that converts ATN string literals toString.fromCharCode()arrays before the oxc printer processes themresolve.aliasforapex-log-parserand align SWC minify options in rolldown configTest plan
pnpm build:dev:fast— rolldown dev build succeedspnpm build:fast— rolldown production build succeedspnpm test— 720/720 tests pass