feat(client): add ocoOrder and example#964
Merged
carlosmiei merged 2 commits intomasterfrom Sep 24, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for OCO (One-Cancels-Other) orders to the Binance API client by introducing a new order type and dedicated method for creating OCO orders.
- Adds 'OCO' as a new OrderType in the type definitions
- Modifies the existing order method to handle OCO orders with appropriate endpoint routing and parameter handling
- Introduces a new
ocoOrdermethod specifically for creating OCO orders with simplified parameters
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/types.ts | Adds 'OCO' to the OrderType union type |
| src/node-binance-api.ts | Updates order method to handle OCO orders and adds new ocoOrder method |
| examples/oco-order.ts | Provides example usage of the new ocoOrder functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| symbol: symbol, | ||
| side: side, | ||
| type: type | ||
| // type: type |
There was a problem hiding this comment.
The commented-out type: type assignment followed by conditional assignment creates confusion. Consider removing the commented line and keeping only the conditional assignment for clarity.
Suggested change
| // type: type |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.