[Misc] MTA Transformer updates

[anirudhprasad-sap]

• Remove TENANT_HOST_PATTERN template value from the Router workload values.yaml and update the corresponding templates
• Remove redirect-uris from oauth2-configuration for xsuaa service instance, as it would be filled by the service-instance.yaml template
• Update consumedBTPServices for Router workload to include all service bindings for the getDependencies call

[hyperspace-insights]

Summary

The following content is AI-generated and provides a summary of the pull request:

---

MTA Transformer Enhancements for CAP Operator

New Features

✨ Enhanced the MTA transformation process to improve the Router workload configuration and streamline service instance handling for CAP Operator deployments.

Changes

• lib/add.js:

  • Added logic to automatically populate the Router workload's consumedBTPServices with all service bindings (excluding html5-apps-repo app-host plan bindings)
  • This ensures the getDependencies call is properly handled by the Router workload

• lib/mta-transformer.js:

  • Removed TENANT_HOST_PATTERN from Router workload environment variables during transformation (now handled by cap-operator-cro.yaml template)
  • Added automatic removal of redirect-uris from XSUAA service instance oauth2-configuration parameters (populated by the service-instance.yaml template instead)
  • Improved code organization and cleanup of redundant logic

• lib/util.js:

  • Refactored transformValuesAndFillCapOpCroYaml function with new helper functions for better maintainability:
    • upsertEnvVar: Sets or updates environment variables in an array
    • extractAndReplaceHanaInstanceId: Extracts HANA instance ID from CDS_CONFIG and replaces with template placeholder
    • appendToSpec: Appends sections to the spec in CRO YAML
  • Simplified the logic for handling Router, CAP, Service, and TenantOperation workload configurations
  • Improved getServiceInstanceKeyName function using modern JavaScript array methods

• README.md:

  • Added documentation note explaining that the Router workload's consumedBTPServices is automatically populated during MTA transformation
  • Included guidance for developers implementing custom getDependencies handlers

• Test files updated to reflect the changes:

  • test/files/expectedChart/valuesWithMTA.yaml
  • test/files/expectedConfigurableTemplatesChart/templates/cap-operator-cros-mta.yaml
  • test/files/mta.yaml

---

• 🔄 Regenerate and Update Summary
• ✏️ Insert as PR Description (deletes this comment)
• 🗑️ Delete comment

PR Bot Information

Version: 1.17.53 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback

• Event Trigger: issue_comment.edited
• LLM: anthropic--claude-4.5-sonnet
• Correlation ID: 8d121fe0-0658-11f1-92da-ecddcbfb9c6c
• Summary Prompt: Default Prompt
• Output Template: Default Template

[hyperspace-insights]

The Pull Request implements support for multiple XSUAA instances and removes TENANT_HOST_PATTERN from values.yaml. The code changes include refactoring and a new feature. I identified several substantive issues including missing null checks that could cause runtime errors, an unused variable, and a missing error handler for JSON parsing. These issues should be addressed to improve code robustness and maintainability.

PR Bot Information

Version: 1.17.50 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback

• Event Trigger: pull_request.opened
• LLM: anthropic--claude-4.5-sonnet
• Correlation ID: 7d368790-029e-11f1-9248-1171939fdee4

[sonarqubecloud]

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Pavan-SAP]

✅