Skip to content

Refactor code style for consistency and readability across multiple f…#374

Merged
KoblerS merged 6 commits intomainfrom
feat-disable-malware-scanner
Feb 16, 2026
Merged

Refactor code style for consistency and readability across multiple f…#374
KoblerS merged 6 commits intomainfrom
feat-disable-malware-scanner

Conversation

@KoblerS
Copy link
Collaborator

@KoblerS KoblerS commented Feb 12, 2026

…iles; add setupDeletionListener utility for improved attachment deletion handling.

Closes #372

…iles; add setupDeletionListener utility for improved attachment deletion handling.
@KoblerS KoblerS self-assigned this Feb 12, 2026
@hyperspace-insights
Copy link
Contributor

Summary

The following content is AI-generated and provides a summary of the pull request:


Refactor code style for consistency and readability across multiple files

♻️ Refactor: Standardized code formatting and improved attachment deletion handling

Changes

This pull request refactors code style across multiple files to ensure consistency and improves the attachment deletion testing utilities. Key changes include:

  • .prettierrc: Added configuration file with 2-space indentation, no tabs, and no semicolons
  • lib/generic-handlers.js: Updated code formatting with consistent quote styles, better line breaks, and improved readability throughout. Changed MAX_FILE_SIZE from a constant to a function that returns -1 (no limit) when malware scanning is disabled
  • lib/helper.js: Reformatted code with consistent styling and improved error handling messages for better debugging
  • tests/incidents-app/package.json: Updated @cap-js/hana dependency from 2.3.4 to 2.6.0
  • tests/integration/attachments-non-draft.test.js: Replaced waitForDeletion() with setupDeletionListener() for more robust event handling
  • tests/integration/attachments.test.js: Added new test case to verify file uploads larger than 400MB succeed when malware scanning is disabled
  • tests/utils/testUtils.js: Introduced setupDeletionListener() utility function for improved attachment deletion handling; deprecated the original waitForDeletion() function

Additional Context

This refactor addresses attachment size restrictions when malware scanning is not enabled, allowing more flexibility in file upload sizes.

Related GitHub Issue

  • #372: Remove attachment size restriction when malware scan is not enabled

  • 🔄 Regenerate and Update Summary
  • ✏️ Insert as PR Description (deletes this comment)
  • 🗑️ Delete comment
PR Bot Information

Version: 1.17.53 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback


💌 Have ideas or want to contribute? Create an issue and share your thoughts with us!
📑 Check out the documentation for more information.
📬 Subscribe to the Hyperspace PR Bot DL to get the latest announcements and pilot features!

Made with ❤️ by Hyperspace.

Copy link
Contributor

@hyperspace-insights hyperspace-insights bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

This PR contains critical bugs introduced during the formatting refactor: a parenthesis mismatch causing syntax error, incorrect function/variable references after API changes, and unsafe test configuration mutations. The code quality issues significantly impact correctness despite the intent being style improvements.

PR Bot Information

Version: 1.17.53 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback

  • Correlation ID: d36d6370-07e6-11f1-9789-f2a24f7853b3
  • LLM: anthropic--claude-4.5-sonnet
  • Event Trigger: pull_request.opened

Co-authored-by: hyperspace-insights[bot] <209611008+hyperspace-insights[bot]@users.noreply.github.com>
@KoblerS KoblerS force-pushed the feat-disable-malware-scanner branch from ae9fe08 to b170538 Compare February 12, 2026 07:54
@KoblerS KoblerS force-pushed the feat-disable-malware-scanner branch 2 times, most recently from 6e4069a to 21740d8 Compare February 16, 2026 07:56
…remove large file upload test with malware scanning disabled
@KoblerS KoblerS force-pushed the feat-disable-malware-scanner branch from 21740d8 to 43802cc Compare February 16, 2026 07:56
@KoblerS KoblerS marked this pull request as ready for review February 16, 2026 09:35
@KoblerS KoblerS requested a review from a team as a code owner February 16, 2026 09:35
@KoblerS KoblerS merged commit 573d84b into main Feb 16, 2026
30 of 31 checks passed
@KoblerS KoblerS deleted the feat-disable-malware-scanner branch February 16, 2026 12:38
KoblerS added a commit that referenced this pull request Feb 16, 2026
#374)

…iles; add setupDeletionListener utility for improved attachment
deletion handling.

Closes #372

---------

Co-authored-by: hyperspace-insights[bot] <209611008+hyperspace-insights[bot]@users.noreply.github.com>
KoblerS added a commit that referenced this pull request Feb 16, 2026
#374)

…iles; add setupDeletionListener utility for improved attachment
deletion handling.

Closes #372

---------

Co-authored-by: hyperspace-insights[bot] <209611008+hyperspace-insights[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove attachment size restriction when malware scan is not enabled

3 participants