Open
Conversation
Do not expose the token used to write the comment to PRs from forks.
lczyk
reviewed
Mar 6, 2026
letFunny
reviewed
Mar 6, 2026
Collaborator
letFunny
left a comment
letFunny
left a comment
There was a problem hiding this comment.
A few comments, thank for looking into this Paul. It would be nice if we can get some guidance for security as well.
3 tasks
cjdcordeiro
requested changes
Mar 9, 2026
cjdcordeiro
reviewed
Mar 10, 2026
cjdcordeiro
approved these changes
Mar 10, 2026
letFunny
approved these changes
Mar 10, 2026
Collaborator
letFunny
left a comment
letFunny
left a comment
There was a problem hiding this comment.
Thank you Paul for taking care of this, it looks great. Let's see how it works once it is merged.
lczyk
approved these changes
Mar 12, 2026
Contributor
|
nit, but you didn't tick 'Have you signed the CLA?' ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not expose the token used to write the comment to PRs from forks.
This also ensures that PRs open from external contributors will not trigger
the workflows.
In the workflow posting the comment, use a fine-grained token with the
minimum permissions (write PR and read Actions).