Skip to content

feat(transpile): Support fixed length lists#1315

Merged
vados-cosmonic merged 3 commits intobytecodealliance:mainfrom
yannbolliger:fixed-length-lists
Mar 18, 2026
Merged

feat(transpile): Support fixed length lists#1315
vados-cosmonic merged 3 commits intobytecodealliance:mainfrom
yannbolliger:fixed-length-lists

Conversation

@yannbolliger
Copy link
Contributor

@yannbolliger yannbolliger commented Mar 18, 2026

Closes #1240

Adds support for Fixed Length Lists to the transpile.

The (likely wrong) implementations for Fixed Length Lists of gen_flat_lower_fn_js_expr and gen_flat_lower_fn_list_js_expr have not been changed.

Copy link
Collaborator

@vados-cosmonic vados-cosmonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Excellent work @yannbolliger -- I only had incredibly minor nits, and am happy to merge this as soon as those are addressed.

@vados-cosmonic
Copy link
Collaborator

vados-cosmonic commented Mar 18, 2026

Ah also @yannbolliger we require conventional commits here (I think that's the only test failing), so here are some commit titles that would be good:

feat(bindgen): implement fixed length lists

(for a commit with all the bindgen changes)

test(jco): add tests for fixed length lists

(for a commit with the changes made to jco test and the rust test components

I can make these changes for you if you'd like!

@yannbolliger
Copy link
Contributor Author

we require conventional commits here

Oh, I thought we were squashing the commits at the end and this only applied to the PR. 👍

@yannbolliger yannbolliger force-pushed the fixed-length-lists branch 2 times, most recently from a7c7765 to 2d427a2 Compare March 18, 2026 14:29
@vados-cosmonic
Copy link
Collaborator

As weird as this sounds, the cc-commits check does not like capital letters to start the commit title:

fix(bindgen): Make all bindings const

auto-merge was automatically disabled March 18, 2026 15:54

Head branch was pushed to by a user without write access

@vados-cosmonic vados-cosmonic added this pull request to the merge queue Mar 18, 2026
Merged via the queue into bytecodealliance:main with commit 272ebb7 Mar 18, 2026
36 checks passed
@yannbolliger yannbolliger deleted the fixed-length-lists branch March 18, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support transpile for fixed size lists

2 participants