fix(p2-shim/fs): correct read/write semantics#1303
Open
MendyBerger wants to merge 1 commit intobytecodealliance:mainfrom
Open
fix(p2-shim/fs): correct read/write semantics#1303MendyBerger wants to merge 1 commit intobytecodealliance:mainfrom
MendyBerger wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
Collaborator
vados-cosmonic
left a comment
There was a problem hiding this comment.
Thanks for this @MendyBerger . This support has been legitimately missing for 2 years at this point. thanks for finally adding it (with good comments and links to the spec!)
This is almost ready to go, only two things:
fix(p2-shim/fs)->fix(p2-shim)(we don't have sub targets yet! totally down to add that, but in another PR we can update the commit linting)- Would you mind adding a regression test?
Collaborator
|
@MendyBerger looks like fmt and lint are failing -- would you mind taking a look? You can run these locally with |
Contributor
Author
|
@vados-cosmonic know why ci didn't start? |
Collaborator
|
@MendyBerger They're configured not to for external contributors |
vados-cosmonic
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
openAtto checkmutateDirectory.Since we're checking flags correctly now, I added read/write flags to preopens.