Skip to content

fix(p2-shim/fs): correct read/write semantics#1303

Open
MendyBerger wants to merge 1 commit intobytecodealliance:mainfrom
MendyBerger:patch
Open

fix(p2-shim/fs): correct read/write semantics#1303
MendyBerger wants to merge 1 commit intobytecodealliance:mainfrom
MendyBerger:patch

Conversation

@MendyBerger
Copy link
Contributor

Fixes openAt to check mutateDirectory.

Since we're checking flags correctly now, I added read/write flags to preopens.

Copy link
Collaborator

@vados-cosmonic vados-cosmonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @MendyBerger . This support has been legitimately missing for 2 years at this point. thanks for finally adding it (with good comments and links to the spec!)

This is almost ready to go, only two things:

  • fix(p2-shim/fs) -> fix(p2-shim) (we don't have sub targets yet! totally down to add that, but in another PR we can update the commit linting)
  • Would you mind adding a regression test?

@vados-cosmonic
Copy link
Collaborator

@MendyBerger looks like fmt and lint are failing -- would you mind taking a look? You can run these locally with npm run lint or npm run fmt which should run across all subprojects!

@MendyBerger
Copy link
Contributor Author

@vados-cosmonic know why ci didn't start?

@vados-cosmonic
Copy link
Collaborator

@MendyBerger They're configured not to for external contributors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants