Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the test configuration generation in
reload_test.goto use strongly-typed Go structs and YAML marshaling instead of manual string formatting. This makes the configuration generation more robust and maintainable. It also adds minor improvements to test logging and disables logging output during tests.Test configuration improvements:
writeConfighelper to build the YAML config using Go struct types andyaml.Marshal, replacing the previous string concatenation approach. This reduces errors and improves maintainability.writeConfigsignature, which now infers the number of targets from the provided directories.Test reliability and output:
TestMainfunction to set the default logger to discard output, preventing unwanted log messages during test runs. [1] [2]Minor code hygiene:
setupCSVDirswhere the loop incorrectly ranged over an integer instead of the directory slice.