add new models and the v3 report#8
Open
yimin-zhao wants to merge 1 commit intobulwahn:masterfrom
yimin-zhao:v3
Open
add new models and the v3 report#8yimin-zhao wants to merge 1 commit intobulwahn:masterfrom yimin-zhao:v3
yimin-zhao wants to merge 1 commit intobulwahn:masterfrom
yimin-zhao:v3
Conversation
Owner
|
Looks good. I will ask Ozan to reproduce your results in bug.txt with the scripts that he is providing in the other pull request #7. Possibly we then split the three changes you did in three result runs, so that we can see the effect of each change in isolation. |
Contributor
Author
|
Yes, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools/directory.