[TE-4628] Remove CI environment variable requirement for uploads#89
Merged
[TE-4628] Remove CI environment variable requirement for uploads#89
Conversation
The presence of BUILDKITE_ANALYTICS_TOKEN is sufficient to determine upload intent. Previously, both CI and token were required, which caused issues for users who carefully manage environment variables in isolated container environments. This change removes the CI check from the API.submit() method while preserving the self.ci attribute for potential future use. Now only BUILDKITE_ANALYTICS_TOKEN determines whether uploads happen. Fixes #74
gchan
force-pushed
the
te-4628-remove-ci-env-var-requirement
branch
from
eb48bdd to
927e439
Compare
niceking
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the requirement for the
CIenvironment variable to be set for test results to be uploaded to Buildkite Test Engine. The presence ofBUILDKITE_ANALYTICS_TOKENis now the sole determinant for whether uploads occur.Previously, PR #71 introduced a check that required both the
CIenvironment variable andBUILDKITE_ANALYTICS_TOKENto be present for uploads to happen. This caused issues for users who carefully manage environment variables in isolated container environments, as reported in #74.The customer feedback highlighted that the
CIvariable is not namespaced underBUILDKITE_*and conflicts with their environment variable management policies. SinceBUILDKITE_ANALYTICS_TOKENis an explicit opt-in signal that users want to upload test results, requiring an additionalCIcheck was unnecessary.This change removes the
CIcheck from theAPI.submit()method while preserving theself.ciattribute for potential future debugging or logging use. The implementation maintains full backward compatibility - users withCIset will continue to work, and users without it can now successfully upload when they have a valid token.Context
Resolves TE-4628
Fixes #74
This addresses customer feedback from aiven-amartin and unblocks gqmelo from upgrading to v1.3.0.
Changes
CIenvironment variable check fromAPI.submit()method inapi.pyCIis not required but warning is logged when token is missingVerification
Backed by specs.
The specs verifies that uploads work when
BUILDKITE_ANALYTICS_TOKENis present butCIis not set.Deployment
Low risk. This change makes the collector more permissive by removing a check, so existing configurations continue to work. Users who were previously blocked by the CI requirement will now be able to upload results.
Rollback
Yes