fix: report teardown failures as failed tests#85
Closed
jimsynz wants to merge 2 commits intobuildkite:mainfrom
Closed
fix: report teardown failures as failed tests#85jimsynz wants to merge 2 commits intobuildkite:mainfrom
jimsynz wants to merge 2 commits intobuildkite:mainfrom
Conversation
Previously, only setup and call phase outcomes were considered when determining test results. If a fixture teardown failed, the test would still be reported as passed to Buildkite Test Analytics. This change extends the phase check to also capture teardown failures, which will override a passed call result. This matches pytest's own behaviour where teardown failures cause the overall test to fail. Fixes buildkite#84
The `numprocesses` option only exists when pytest-xdist is installed.
Previously, `config.getoption("numprocesses")` was called unconditionally,
causing a ValueError when xdist wasn't present.
Contributor
|
@jimsynz this looks great. Could you please resolve the conflict as result of a recent merge. Context: https://github.com/buildkite/test-collector-python/pull/83/changes#r2715206637 I'm going to prepare a new release of the collector to add support for #83 , so it would be great to get this in too! |
3 tasks
Contributor
|
Closing in favor of #86 which contains the rebased commits with conflict resolution. See the new PR for details on the rebase and merge conflict resolution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #84
Changes
1. Report teardown failures
The condition in
pytest_runtest_logreportnow handles teardown failures the same way it handles setup failures - capturing them to override the test result.2. Fix xdist option access when xdist not installed
The
numprocessesoption only exists when pytest-xdist is installed. Previously,config.getoption("numprocesses")was called unconditionally, causing aValueErrorwhen xdist wasn't present. This was breaking CI.Test plan
test_pytest_runtest_logreport_fail_exception_in_teardownthat verifies teardown failure overrides a passed call result