Open
Conversation
Contributor
|
@adamrdavid what do you think about putting this check in |
f58ba8f to
7531e5a
Compare
Contributor
Author
|
@maschwenk the error that get's raised when string is nil comes from I have updated the readme to better describe the situation. |
Contributor
|
@adamrdavid I guess it makes no sense to try to cache invalid |
7531e5a to
e0c9cb4
Compare
Contributor
Author
|
At any rate this needs to be added to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make
VRT::Map#find_nodemore durable to unexpected inputVRT::Map#find_nodeChecklist:
version.rb