refactor(generator): consolidate typing imports from typing_extensions#17
Open
yie1d wants to merge 1 commit intobrowser-use:mainfrom
Open
refactor(generator): consolidate typing imports from typing_extensions#17yie1d wants to merge 1 commit intobrowser-use:mainfrom
yie1d wants to merge 1 commit intobrowser-use:mainfrom
Conversation
- Move NotRequired and TypedDict imports from typing_extensions to typing module in command_generator.py - Move NotRequired and TypedDict imports from typing_extensions to typing module in event_generator.py - Move NotRequired and TypedDict imports from typing_extensions to typing module in type_generator.py - Move Literal import from typing_extensions to typing module in type_generator.py - Consolidate multiple import statements into single import line for better readability - Reduces dependency on typing_extensions by using Python 3.10+ standard library types
Author
|
solve #16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Refactored generator imports to use Python 3.10+ typing (NotRequired, TypedDict, Literal) and merged duplicate import lines for cleaner files. This removes the typing_extensions dependency and keeps imports consistent across command, event, and type generators.
Written for commit 3bd870b. Summary will update on new commits.