Skip to content

add aws checksum for gcp #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jeff McCollum (jeffmccollum) merged 1 commit into from
Mar 23, 2026
+28 −0
Merged

add aws checksum for gcp #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions braintrust/templates/api-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ data:
ENABLE_GCS_AUTH: "true"
{{- else }}
AWS_ENDPOINT_URL: "https://storage.googleapis.com"
AWS_REQUEST_CHECKSUM_CALCULATION: "WHEN_REQUIRED"
AWS_RESPONSE_CHECKSUM_VALIDATION: "WHEN_REQUIRED"
{{- end }}
{{- end }}

Expand Down
26 changes: 26 additions & 0 deletions braintrust/tests/api-configmap_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,32 @@ tests:
- equal:
path: data.AWS_ENDPOINT_URL
value: "https://storage.googleapis.com"
- equal:
path: data.AWS_REQUEST_CHECKSUM_CALCULATION
value: "WHEN_REQUIRED"
- equal:
path: data.AWS_RESPONSE_CHECKSUM_VALIDATION
value: "WHEN_REQUIRED"

- it: should not set checksum vars when enableGcsAuth is true
values:
- __fixtures__/base-values.yaml
- __fixtures__/google-values.yaml
set:
api.enableGcsAuth: true
api.serviceAccount.googleServiceAccount: "test@project.iam.gserviceaccount.com"
release:
namespace: "braintrust"
asserts:
- equal:
path: data.ENABLE_GCS_AUTH
value: "true"
- isNull:
path: data.AWS_ENDPOINT_URL
- isNull:
path: data.AWS_REQUEST_CHECKSUM_CALCULATION
- isNull:
path: data.AWS_RESPONSE_CHECKSUM_VALIDATION

- it: should configure brainstore URLs correctly
values:
Expand Down
Loading