propogate err to condRelease in withAddrRw#170
propogate err to condRelease in withAddrRw#170jlisthood wants to merge 1 commit intobradfitz:masterfrom
Conversation
|
@bradfitz apologies for the ping, but do you believe change is necessary? I imagine the worst case is that In our private fork of gomemcache, we actually changed We did this but then we found that during network difficulties we would eventually see It seems like |
|
Note: think this relates to a bunch of issues about errors getting eaten. |
Currently,
withAddrRwalways callsdefer cn.condRelease(&err)with an err that is nil. This means no matter what error happens infn, the connection will get sent back to the pool even if there is a non-resumable error. This isn't ideal because we could be sending bad connections back to the pool.This PR matches the implementation with
onItemthat seems to handle the error correctly.