Skip to content

Communicate FieldPerp consistently with other Fields#3323

Merged
ZedThree merged 3 commits intonextfrom
communicate-fieldperp-v2
Mar 16, 2026
Merged

Communicate FieldPerp consistently with other Fields#3323
ZedThree merged 3 commits intonextfrom
communicate-fieldperp-v2

Conversation

@ZedThree
Copy link
Member

Simpler but perhaps less elegant alternative to #3321

  • Add Field::field_type() virtual method
  • Removes Mesh::communicate(FieldPerp&) overload

@ZedThree ZedThree requested a review from bendudson March 12, 2026 17:32
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

- Add `Field::field_type()` virtual method
- Removes `Mesh::communicate(FieldPerp&)` overload
@ZedThree ZedThree force-pushed the communicate-fieldperp-v2 branch from 8a20105 to 0528579 Compare March 13, 2026 09:33
dschwoerer
dschwoerer previously approved these changes Mar 13, 2026
Copy link
Contributor

@dschwoerer dschwoerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good 👍

@dschwoerer
Copy link
Contributor

Now is3D() could be deprecated, and also be made non-virtual, as it only needs to check the field_type.

@ZedThree
Copy link
Member Author

Now is3D() could be deprecated, and also be made non-virtual, as it only needs to check the field_type.

Good points!

@ZedThree ZedThree changed the title Communicate FieldPerp consistently with other Fields (other version) Communicate FieldPerp consistently with other Fields Mar 13, 2026
@ZedThree ZedThree merged commit d9f2a66 into next Mar 16, 2026
23 checks passed
@ZedThree ZedThree deleted the communicate-fieldperp-v2 branch March 16, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants