tests: add 64K block size expected outputs for ppc64#561
Open
amaanq wants to merge 1 commit intobootandy:masterfrom
Open
tests: add 64K block size expected outputs for ppc64#561amaanq wants to merge 1 commit intobootandy:masterfrom
amaanq wants to merge 1 commit intobootandy:masterfrom
Conversation
The existing tests hardcode 4K block size expectations, which fail on systems with 64K block sizes (this is common on ppc64/POWER). This extends the valid output variants to include 64K.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing tests hardcode 4K block size expectations, which fail on systems with 64K block sizes (this is common on ppc64/POWER). This extends the valid output variants to include 64K.
I've tested this locally on a POWER8 machine I have access to, and the tests pass.