Add epoch_ns_for for PlainDate/Time/DateTime#699
Closed
Manishearth wants to merge 2 commits intoboa-dev:mainfrom
Closed
Add epoch_ns_for for PlainDate/Time/DateTime#699Manishearth wants to merge 2 commits intoboa-dev:mainfrom
Manishearth wants to merge 2 commits intoboa-dev:mainfrom
Conversation
jedel1043
reviewed
Mar 19, 2026
Member
jedel1043
left a comment
jedel1043
left a comment
There was a problem hiding this comment.
Looks good. I just have a small doc fix
| ) | ||
| } | ||
|
|
||
| /// Gets the epochMilliseconds represented by this PlainDate in the given timezone |
Member
There was a problem hiding this comment.
Suggested change
| /// Gets the epochMilliseconds represented by this PlainDate in the given timezone | |
| /// Gets the EpochNanoseconds represented by this PlainDate in the given timezone |
Also applies to the rest of the new methods
Contributor
Author
|
Actaully, it turns out this doesn't fix the issue since we still range-check here. PLUS the API shape changed here; since it doesn't need the time zone anymore (see tc39/proposal-temporal#3212) I'll redo this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out we need them, just converting to ZDT isn't enough since ZDT can be out-of-range
https://g-issues.chromium.org/489023921