fix(runtime): support cloning DataView objects#5235
Open
yush-1018 wants to merge 1 commit intoboa-dev:mainfrom
Open
fix(runtime): support cloning DataView objects#5235yush-1018 wants to merge 1 commit intoboa-dev:mainfrom
yush-1018 wants to merge 1 commit intoboa-dev:mainfrom
Conversation
github-actions
bot
added
Waiting On Review
Test262 conformance changes
Tested main commit: |
jedel1043
requested changes
Mar 23, 2026
| /// - [TC39 proposal][spec] | ||
| /// | ||
| /// [spec]: https://tc39.es/proposal-joint-iteration/#sec-iterator.zip | ||
| fn zip(_: &JsValue, args: &[JsValue], context: &mut Context) -> JsResult<JsValue> { |
Member
There was a problem hiding this comment.
I think you pushed unrelated commits from another PR 😅
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5235 +/- ##
===========================================
+ Coverage 47.24% 59.77% +12.52%
===========================================
Files 476 589 +113
Lines 46892 63418 +16526
===========================================
+ Hits 22154 37906 +15752
- Misses 24738 25512 +774 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yush-1018
force-pushed
the
fix-dataview-clone
branch
from
6535f5c to
8fec740
Compare
github-actions
bot
added
the
Waiting On Review
Contributor
Author
|
Sorry about that! I've force-pushed with only the relevant DataView fix commit now. Could you re-review? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5167
This PR adds support for
structuredClone()to cloneDataViewobjects. Let me know if anything needs changes!