Skip to content

Implement Error.prototype.stack accessor property#4552

Open
HalidOdat wants to merge 1 commit intoboa-dev:mainfrom
HalidOdat:feature/error-stack-property
Open

Implement Error.prototype.stack accessor property#4552
HalidOdat wants to merge 1 commit intoboa-dev:mainfrom
HalidOdat:feature/error-stack-property

Conversation

@HalidOdat
Copy link
Member

@HalidOdat HalidOdat commented Nov 30, 2025

This implements the Error.prototype.stack property as specified in the TC39 Error Stacks proposal (https://tc39.es/proposal-error-stacks).

@github-actions
Copy link

github-actions bot commented Nov 30, 2025

Test262 conformance changes

Test result main count PR count difference
Total 52,598 52,598 0
Passed 49,421 49,422 +1
Ignored 2,134 2,134 0
Failed 1,043 1,042 -1
Panics 0 0 0
Conformance 93.96% 93.96% +0.00%
Fixed tests (1):
test/staging/sm/extensions/regress-645160.js (previously Failed)

@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

❌ Patch coverage is 71.79487% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.83%. Comparing base (6ddc2b4) to head (4c3de18).
⚠️ Report is 918 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/builtins/error/mod.rs 44.18% 24 Missing ⚠️
core/engine/src/vm/shadow_stack.rs 87.75% 6 Missing ⚠️
core/engine/src/value/display/value.rs 0.00% 2 Missing ⚠️
core/engine/src/error/mod.rs 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4552       +/-   ##
===========================================
+ Coverage   47.24%   59.83%   +12.59%     
===========================================
  Files         476      589      +113     
  Lines       46892    63447    +16555     
===========================================
+ Hits        22154    37966    +15812     
- Misses      24738    25481      +743     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@HalidOdat HalidOdat force-pushed the feature/error-stack-property branch 2 times, most recently from 6e5752d to 301a7d8 Compare January 7, 2026 17:21
@HalidOdat HalidOdat force-pushed the feature/error-stack-property branch 3 times, most recently from a932134 to 286ebec Compare January 25, 2026 17:28
@HalidOdat HalidOdat marked this pull request as ready for review January 25, 2026 17:30
@HalidOdat HalidOdat requested a review from a team January 25, 2026 17:54
@jedel1043 jedel1043 added A-Enhancement New feature or request C-Builtins PRs and Issues related to builtins/intrinsics labels Feb 27, 2026
@jedel1043 jedel1043 modified the milestone: v1.0.0 Feb 27, 2026
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really liking all the improvements on the names and the display of the error stack!

This commit implements the Error.prototype.stack property as specified
in the TC39 Error Stacks proposal (https://tc39.es/proposal-error-stacks).
@HalidOdat HalidOdat force-pushed the feature/error-stack-property branch from 286ebec to 4c3de18 Compare March 24, 2026 16:17
@github-actions github-actions bot added Waiting On Review Waiting on reviews from the maintainers C-VM Issues and PRs related to the Boa Virtual Machine. labels Mar 24, 2026
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 52,963 52,963 0
Passed 50,732 50,732 0
Ignored 1,426 1,426 0
Failed 805 805 0
Panics 0 0 0
Conformance 95.79% 95.79% 0.00%

Tested main commit: 8fcbfcbb8b9e70fe878d28376a6496eaa57a70d7
Tested PR commit: 4c3de18419c0e5954bcb467ecf6f6525c8a25229
Compare commits: 8fcbfcb...4c3de18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Enhancement New feature or request C-Builtins PRs and Issues related to builtins/intrinsics C-VM Issues and PRs related to the Boa Virtual Machine. Waiting On Review Waiting on reviews from the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants