improvement(update): Updated all supported php images#38
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
8.1/bookworm/apache/Dockerfile
Outdated
| apt-get update && apt-get install -y --no-install-recommends python3 python3-distutils python3-pip; \ | ||
| \ | ||
| # install ansible | ||
| pip install --no-cache-dir ansible-core==${ANSIBLE_CORE_VERSION} |
There was a problem hiding this comment.
The ansible build stage installs python3-pip from Debian bookworm and then runs pip install --no-cache-dir ansible-core==${ANSIBLE_CORE_VERSION} without --break-system-packages. Debian’s patched pip refuses to modify the system interpreter unless that flag is provided (see /usr/lib/python3.11/EXTERNALLY-MANAGED), so this step will abort with an “externally-managed-environment” error and the image build fails. All other Debian-based Dockerfiles in this commit include the flag, so it looks accidental. Please add --break-system-packages to the pip invocation in this stage.
Useful? React with 👍 / 👎.
8.1/trixie/apache/Dockerfile
Outdated
| apt-get update && apt-get install -y --no-install-recommends python3 python3-distutils python3-pip; \ | ||
| \ | ||
| # install ansible | ||
| pip install --no-cache-dir ansible-core==${ANSIBLE_CORE_VERSION} |
There was a problem hiding this comment.
The new trixie ansible stage also invokes pip install --no-cache-dir ansible-core==${ANSIBLE_CORE_VERSION} without --break-system-packages. On Debian trixie the pip package is externally managed and will reject global installs unless that flag is present, causing the build to fail before the final image is produced. Consider aligning this pip command with the other Debian-based Dockerfiles in the repo by adding --break-system-packages.
Useful? React with 👍 / 👎.
g0blin79
force-pushed
the
37_update_docker_images_at_php_latest_versions
branch
from
be0101e to
39a4f74
Compare
g0blin79
force-pushed
the
37_update_docker_images_at_php_latest_versions
branch
from
39a4f74 to
1641f2c
Compare
1 participant
No description provided.