Skip to content

Feat: add peam quickstart docker integration#141

Merged
ch4r10t33r merged 1 commit intoblockblaz:mainfrom
malik672:peam
Mar 20, 2026
Merged

Feat: add peam quickstart docker integration#141
ch4r10t33r merged 1 commit intoblockblaz:mainfrom
malik672:peam

Conversation

@malik672
Copy link
Contributor

This PR adds Peam to lean-quickstart as a supported local devnet client.

Copy link
Contributor

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pls add the necessary files for ansible devnet as well. Pls leave the server as empty. I'll fill that up.

@ch4r10t33r
Copy link
Contributor

ch4r10t33r commented Mar 20, 2026

Review notes

1. Docker image extraction pattern
The guide’s template extracts the image from ^node_docker=... with a grep -oE '...image:tag'. Peam’s node_docker starts with "$peam_docker_image \, so that pattern wouldn’t work; the role correctly uses a custom peam_docker_image= + sed. Consider either documenting this variant in the guide or reshaping node_docker so the standard extraction still applies.

2. Image tag inconsistency
ansible/roles/peam/defaults/main.yml uses ghcr.io/malik672/peam:sha-c29d566 while client-cmds/peam-cmd.sh defaults to ghcr.io/malik672/peam:sha-7ad325c. Ansible fallback and local spin-node can disagree on which image runs — worth aligning on a single tag.

3. metricsPort and apiPort both 5059
The doc’s examples use distinct ports for metrics vs HTTP API. Unless Peam serves both on one listener, this may fail at bind time or confuse scraping; consider splitting (e.g. metrics on a high port, API on 505x).

@ch4r10t33r
Copy link
Contributor

ch4r10t33r commented Mar 20, 2026

For the full integration checklist (all 6 touch points), see the guide on the subnets branch: https://github.com/blockblaz/lean-quickstart/blob/subnets/docs/adding-a-new-client.md

@malik672
Copy link
Contributor Author

For the full integration checklist (all 6 touch points), see the guide on the subnets branch: https://github.com/blockblaz/lean-quickstart/blob/subnets/docs/adding-a-new-client.md

done

Copy link
Contributor

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ch4r10t33r
Copy link
Contributor

@malik672 can you confirm peam supports metrics?

@malik672
Copy link
Contributor Author

@malik672 can you confirm peam supports metrics?

Yes, peam supports Prometheus metrics. It exposes a /metrics endpoint and now uses a separate metrics port in quickstart/ansible (metricsPort) from the HTTP API port (apiPort).

@malik672 malik672 requested a review from ch4r10t33r March 20, 2026 15:33
@ch4r10t33r ch4r10t33r merged commit 9765190 into blockblaz:main Mar 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants