Skip to content

Acid chozo plm block fix#318

Merged
blkerby merged 4 commits intoblkerby:mainfrom
nn357:acid_chozo_plm_block_fix
Mar 19, 2026
Merged

Acid chozo plm block fix#318
blkerby merged 4 commits intoblkerby:mainfrom
nn357:acid_chozo_plm_block_fix

Conversation

@nn357
Copy link
Contributor

@nn357 nn357 commented Mar 17, 2026

maybe look through it before merging.. should be fine (tested it) but sleepy...

@jeboo
Copy link
Contributor

jeboo commented Mar 18, 2026

Tested out fine here.

@nn357 nn357 marked this pull request as draft March 18, 2026 14:14
@nn357
Copy link
Contributor Author

nn357 commented Mar 18, 2026

just toying with some ideas to remove external calls

routine is now self contained by removing duplicate code.

Co-Authored-By: jeboo <jeboo@users.noreply.github.com>
@nn357 nn357 marked this pull request as ready for review March 18, 2026 15:01
@blkerby
Copy link
Owner

blkerby commented Mar 19, 2026

We have another variant of the "Spawn hard-coded PLM" routine in escape.asm so I added the SEI/CLI there too. At some point it might be worth being proactive and searching for all the places in the ROM that use hardware multiplication and patching them all to disable IRQ.

@blkerby blkerby merged commit e0db812 into blkerby:main Mar 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants