Add Batch Upgrade Operations and Fix Reconciler/Orphan Handling Bugs#58
Merged
krutten merged 17 commits intoblacksmith-community:mainfrom Feb 13, 2026
Merged
Add Batch Upgrade Operations and Fix Reconciler/Orphan Handling Bugs#58krutten merged 17 commits intoblacksmith-community:mainfrom
krutten merged 17 commits intoblacksmith-community:mainfrom
Conversation
Problem: BOSH connection pool (default 4) was shared between general API operations and batch upgrades. When multiple batch jobs ran simultaneously, they exhausted the pool, causing API calls like GetDeployment to fail. Solution: - Create BatchDirector with its own semaphore-based connection pool - Only UpdateDeployment (the blocking operation) uses the batch pool - Other methods pass through to base director without rate limiting Additional changes: - Link max_batch_jobs setting to BatchDirector pool size - Sync pool with Vault settings at startup - Add MaxBatchConnections config option (default: 10)
…ather than vm-monitor
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
krutten
approved these changes
Feb 12, 2026
Contributor
krutten
left a comment
There was a problem hiding this comment.
Additional functionality looks good. Addition to Mocks present and abstraction seems clean. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces batch upgrade capabilities for service instances and fixes critical bugs in the reconciler's orphan detection logic.
New Features
Batch Service Upgrades
VM Monitor Enhancements
Bug Fixes
Reconciler & Orphan Handling (Critical)
Web UI Fixes
Files Changed