Add CRTP protocol v11 support for param MISC commands #589
+36
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use new V2 commands (MISC_GET_EXTENDED_TYPE_V2, MISC_GET_DEFAULT_VALUE_V2) when protocol >= 11 to get unambiguous success/error responses.
There was a problem hiding this comment.
Pull request overview
This PR adds support for CRTP protocol version 11, introducing new V2 commands for parameter MISC operations that provide unambiguous success/error responses. The implementation maintains full backward compatibility with older protocol versions.
Changes:
- Added two new command constants for V2 MISC operations (MISC_GET_EXTENDED_TYPE_V2 and MISC_GET_DEFAULT_VALUE_V2)
- Updated
get_default_value()method to use V2 command format when protocol version >= 11 - Updated
_ExtendedTypeFetcherclass to use V2 command format when protocol version >= 11
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use new V2 commands (
MISC_GET_EXTENDED_TYPE_V2,MISC_GET_DEFAULT_VALUE_V2) when CRTP protocol >= 11 (requires bitcraze/crazyflie-firmware#1594) to get unambiguous success/error responses.