Open
Conversation
Contributor
|
It might depend on the browser? I'm not sure what exactly that race is. There's another race in loader.js . These 2 lines Since the scripts load async and the second one requires the first to already be loaded if they happen to load in the opposite order then it fails. That is fixed by the AMD loader since dependencies can be more explicit. There's also a few circular dependencies which AFAICT are most ok (the aren't used until both loaded) but it would probably be good to remove the circles |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #126 race condition issue.