Visually distinct triplets (simple version) #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… through the whole beat for each stroke, as was done in previous version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mostly contains work from @manumeter, with changes by @estellecomment. It's a simpler version than PR #135 , based on the discussion in issue #125
For time=12 and time=24, when the rhythm is ternary, it displays 3 subdivisions instead of 4 and changes the color to pink.
It also adds the option for time=24 ("4/4 with sextuplets"), with English, French and German translation.
In Compose mode, time=12
In Listen mode, time=24
The color pink is chosen because it's a RoR color, and the UX doesn't have a color scheme (apart from the blue used for links all over the UI)
Time=24 is added here because it's one of the main times for which this feature was needed. It's currently displayed very wide with very few subdivisions, so it's not very easy to read. That will be fixed in another PR : change of width, and maybe display of more subdivisions.